Skip to content

[network_info_plus] Add missing changelog update#655

Merged
mhadaily merged 1 commit intofluttercommunity:mainfrom
vbuberen:fix/changelogs
Dec 29, 2021
Merged

[network_info_plus] Add missing changelog update#655
mhadaily merged 1 commit intofluttercommunity:mainfrom
vbuberen:fix/changelogs

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

Description

In #653 I forgot to update changelog file and missed the fact that pub check failed on Github Actions 🤦🏻‍♂️
So 2.1.2 on pub.dev has no changelogs.

This PR fixes this issue.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily
Copy link
Copy Markdown
Member

@vbuberen

not sure why our CI is stuck, but if you think is safe, I can merged this PR?should we release a new package too right?

@mhadaily mhadaily merged commit 03ff98d into fluttercommunity:main Dec 29, 2021
@vbuberen
Copy link
Copy Markdown
Collaborator Author

vbuberen commented Dec 29, 2021

@mhadaily The version mentioned in changelog changes from this PR was released already on pub.dev. It is just missing the changelog information.

@vbuberen vbuberen deleted the fix/changelogs branch December 29, 2021 14:13
@mhadaily
Copy link
Copy Markdown
Member

thank you @vbuberen

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants